Update fuentes function to ensure floating-point dtype for temperatur…#2620
Closed
DarklordIITG wants to merge 1 commit intopvlib:mainfrom
Closed
Update fuentes function to ensure floating-point dtype for temperatur…#2620DarklordIITG wants to merge 1 commit intopvlib:mainfrom
DarklordIITG wants to merge 1 commit intopvlib:mainfrom
Conversation
…e calculations and adjust corresponding test expectations
Member
|
@DarklordIITG #2618 is addressing this issue. Thanks for the offer here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize tmod_array with dtype=float in temperature.fuentes to avoid integer truncation when inputs are integer-typed.
Update test_fuentes_timezone expected outputs to the correct float values.
[x] Closes #2618
[x] I am familiar with the contributing guidelines
[ ] Tests added (no new tests; we updated existing expectations)
[ ] Updates entries in docs reference (none needed; no API change)
[ ] Adds description/name in whatsnew (optional; could add a short note under bug fixes)
[x] New code is fully documented (no new API; inline comment added for dtype reason)
[x] Pull request is nearly complete and ready for detailed review
[ ] Maintainer labels/milestone (for maintainers)
Tests
python -m pytest tests/test_temperature.py -k fuente